feat: Add constants for Well-Known URIs #271
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is a refactoring effort aimed at improving the codebase's readability and maintainability. My primary goal was to eliminate the use of hardcoded 'magic strings' for well-known URIs by centralizing their definitions into a new constants module. All relevant client and server components have been updated to utilize these new constants, making the system more robust and easier to manage.
Highlights
- Code Refactoring: Centralized URI Constants: I've introduced a new file,
src/a2a/utils/constants.py, to centralize the definitions of well-known URIs. This includesAGENT_CARD_WELL_KNOWN_PATH,EXTENDED_AGENT_CARD_PATH, andDEFAULT_RPC_URL. - Improved Maintainability: Eliminating Magic Strings: I've replaced hardcoded 'magic string' URIs with the newly defined constants across various client and server modules. This enhances readability, reduces the chance of errors from typos, and simplifies future updates to these paths.
- Minor Code Enhancements: I've also added
-> Nonereturn type hints to several__init__methods for better type clarity and applied minor formatting adjustments (e.g., wrapping method calls in parentheses) for consistency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
holtskinner
changed the title
Prevents usage of "Magic Strings"